Added HP full config parsing by joewesch · Pull Request #776 · networktocode/netutils

joewesch · 2026-01-14T17:01:00Z

Closes: #752

NTC-4804

This PR adds a more robust config example as well as some edge cases for the HP Comware platform and adds a custom parser method to properly parse the different sections.

I also was confused which class to update initially, but then I noticed that the HPComwareConfigParser class wasn't really doing much by itself and was redundant. I consolidated the two classes and then added some deprecation warnings and updated the parser to directly use the HPEConfigParser class.

itdependsnetworks · 2026-01-14T17:27:41Z

can you add a compliance check here: https://github.com/networktocode/netutils/tree/develop/tests/unit/mock/config/compliance/compliance

I am interested to see how you define the scope of the configs when there is a space at the start of the line, and would ask that we consider how that will work with GC

joewesch · 2026-01-14T17:54:08Z

can you add a compliance check here: https://github.com/networktocode/netutils/tree/develop/tests/unit/mock/config/compliance/compliance

I am interested to see how you define the scope of the configs when there is a space at the start of the line, and would ask that we consider how that will work with GC

Hmm, ok. In that case I'd probably just lstrip() all config lines without parents.

itdependsnetworks · 2026-01-14T18:57:59Z

can you add a compliance check here: https://github.com/networktocode/netutils/tree/develop/tests/unit/mock/config/compliance/compliance
I am interested to see how you define the scope of the configs when there is a space at the start of the line, and would ask that we consider how that will work with GC

Hmm, ok. In that case I'd probably just lstrip() all config lines without parents.

That may come with other issues for compliance or remediation. Once you put in a compliance test I will take a look at how it works. Pinging @jeffkala on this as well.

…configs)

joewesch · 2026-01-14T20:14:14Z

Ok, I have added the compliance tests as requested.

I have also changed the parser to allow the following to be equivalent so that you don't need to format the intended config in the same manner as the backup config (always separate sections by comments):

vlan 1
#
vlan 101
  name 101

vlan 1
vlan 101
  name 101

itdependsnetworks · 2026-01-15T12:42:31Z

tests/unit/mock/config/compliance/compliance/hp_comware/hp_comware_full_intended.txt

@@ -0,0 +1,208 @@
+#
+sysname NTC-Router


Shouldn't the intended be the same spatially aware configs as the backup?

They don't even match across platforms sometimes.

Space

No Space

I made it space agnostic for single config lines. Both work. Do you want to require that the intended config match the space exactly?

Do you want to require that the intended config match the space exactly?

I don't know for sure. I just want to be purposeful and consider how it effects GC.

We met internally about this. The conclusion is the following:

We will not lstrip any lines

If the backup has a leading space, the config will be parsed with it

Any intended configuration will be required to match exactly (including any leading spaces)

Intended configuration will also require # symbols as they are used to distinguish new sections of configuration

jeffkala · 2026-01-16T17:27:20Z

tests/unit/mock/config/compliance/compliance/hp_comware/hp_comware_full_backup.txt

+#
+ tftp client source interface M-GigabitEthernet0/0/0
+#
+ header motd % 


Is header actually indented 1 space? Seems odd that its nested under seemingly the acl parent?

jeffkala · 2026-01-16T17:31:28Z

tests/unit/mock/config/parser/base/hp_comware/hp_comware_full_sent.txt

+#
+ tftp client source interface M-GigabitEthernet0/0/0
+#
+ header motd % 


same as previous find this weird and want to make sure this is truly 1 space'd in...in the backup from the device.

joewesch · 2026-01-23T19:51:10Z

@itdependsnetworks and @jeffkala

I have updated the parsing to include the leading spaces.

Parsing example

Backup

#
 sysname NTC123456
#

Parsed ConfigLine

ConfigLine(config_line=" sysname NTC123456", parents=()),

The compliance, however is automatically stripping leading spaces here:

netutils/netutils/config/compliance.py

Line 471 in 24c40b6

return "\n".join(section_config_list).strip()

As such, compliance for single config lines don't have leading spaces unless we refactor the section_config function.

Compliance example

Backup

#
 sysname NTC123456
#

Intended

#
 sysname NTC-Router
#

Compliance

    "sysname": {
        "compliant": false,
        "missing": "sysname NTC-Router",
        "extra": "sysname NTC123456",
        "cannot_parse": true,
        "unordered_compliant": false,
        "ordered_compliant": false,
        "actual": "sysname NTC123456",
        "intended": "sysname NTC-Router"
    },

itdependsnetworks · 2026-01-24T15:41:43Z

okay, likely can move forward with this PR, but then will have to circle back for the full strip challenge. Will sync with Jeff before merging.

joewesch · 2026-01-26T19:01:34Z

As we discussed, I have made the following changes:

I reverted the deprecation of the HPComwareConfigParser and instead deprecated the public HPEConfigParser class in lieu of a private _HPEConfigParser base class
I have implemented the logic to skip stripping the leading spaces of configs for specific network_os (currently only hp_comware)

I have also tested this change in my local golden config development environment to verify the changes:

* Changed stripping whitespace for specific network_os

Added HP full config parsing

69bdff4

joewesch requested review from itdependsnetworks, jeffkala and qduk as code owners January 14, 2026 17:01

Added lstrip for all config lines without parents

6fd7bdf

joewesch added 3 commits January 14, 2026 14:11

Removed duplicate lines

12e65b2

Changed parser to not require comment for new sections (for intended …

d157f0f

…configs)

Added compliance tests

f141bdb

itdependsnetworks reviewed Jan 15, 2026

View reviewed changes

jeffkala reviewed Jan 16, 2026

View reviewed changes

Removes default lstrip for all hp config lines

f4fd378

joewesch added 2 commits January 26, 2026 12:46

Restores HP Comware class and moves base class to internal

e5434fa

Changed stripping whitespace for specific network_os

062470f

itdependsnetworks approved these changes Jan 27, 2026

View reviewed changes

jeffkala approved these changes Jan 27, 2026

View reviewed changes

jeffkala merged commit b3a305b into develop Jan 27, 2026
13 checks passed

jeffkala deleted the u/joewesch-hp-parsing branch January 27, 2026 03:09

joewesch mentioned this pull request Jan 30, 2026

Release v3.0.2 nautobot/nautobot-app-golden-config#1077

Merged

michalis1 pushed a commit to michalis1/netutils that referenced this pull request Feb 2, 2026

Added HP full config parsing (networktocode#776)

381a1e0

* Changed stripping whitespace for specific network_os

Conversation

joewesch commented Jan 14, 2026

Uh oh!

itdependsnetworks commented Jan 14, 2026

Uh oh!

joewesch commented Jan 14, 2026

Uh oh!

itdependsnetworks commented Jan 14, 2026

Uh oh!

joewesch commented Jan 14, 2026

Uh oh!

itdependsnetworks Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

joewesch Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

joewesch Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

itdependsnetworks Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

joewesch Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

jeffkala Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

jeffkala Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

joewesch commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Backup

Parsed ConfigLine

Backup

Intended

Compliance

Uh oh!

itdependsnetworks commented Jan 24, 2026

Uh oh!

joewesch commented Jan 26, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

joewesch Jan 15, 2026 •

edited

Loading

joewesch commented Jan 23, 2026 •

edited

Loading